Code Generation for QASM2 #555
Conversation
…its and quantum bits in/out of paranthesis).
…ses to fit updated way of calling emit.
…and update related tests.
|
@zhenrongliew is this PR ready to review? the CI is failing tho |
Seems like not yet. I will take a look at the failing tests |
…ring in Squin to Stim conversion tests
…od in EmitStimFrame
|
@Roger-luo @kaihsin It seems the CI is failiing because it cannot import "kirin.dialects.ssacfg". Is this because the CI is tied to Kirin 0.17? |
…ode generation base `EmitABC` now contains them.
|
@Roger-luo @kaihsin, this is PR should be ready for review. The codegen for The CI complaints is due to some changes in Further errors are due to MeasureID and AddressAnalysis still being refactored. |
There was a problem hiding this comment.
Looks pretty solid.
@Roger-luo @kaihsin just remember when reviewing that we are not merging into main, but another intermediate branch. So failing tests are fine.
| if not self.allow_global: | ||
| # rewrite global to parallel | ||
| GlobalToParallel(dialects=entry.dialects)(entry) | ||
| # if not self.allow_global: |
There was a problem hiding this comment.
Let's remember to uncomment these as soon as we have the new address analysis.
There was a problem hiding this comment.
the new Address analysis is there in the base branch but it is still blocked because I need to update it for Kirin 0.20
Removed commented `Method` constructor Co-authored-by: David Plankensteiner <david-pl@users.noreply.github.com>
Refactor QASM2's code generation to use the new Emit APIs.